Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle parsing errors in XMLStackParser #3

Closed
MaxDesiatov opened this issue Nov 20, 2018 · 0 comments
Closed

Correctly handle parsing errors in XMLStackParser #3

MaxDesiatov opened this issue Nov 20, 2018 · 0 comments
Assignees
@hodovani
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MaxDesiatov
Copy link
Collaborator

Currently there's a single use of print in the codebase for printing an error here. I'm not sure that the error is correctly propagated outside to users of XMLCoder, this needs to be changed to correctly use throw.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hodovani hodovani

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaxDesiatov @hodovani