CONFIG_ASUS_ARMOURY needs to be enabled for all desktops.

[flukejones]

I just got notice from a cachy user on asus that they don't have full functionality available. It looks like CONFIG_ASUS_ARMOURY is enabled only for deckify?

A side note: My latest patches from https://github.com/flukejones/linux/tree/wip/ally-6.12 are now safe for clang compilation (if that was ever an issue - tested with serpentOS).

[1Naim]

Hi Luke, what device is your user using? We currently only pull your ASUS patches for the handheld kernel.

[flukejones]

Laptop. This driver is required for all asus rog and tuf laptops from 2021+.

It is in the process of being upstreamed and has had reviews - just a little more work to do.

[ptr1337]

Laptop. This driver is required for all asus rog and tuf laptops from 2021+.

It is in the process of being upstreamed and has had reviews - just a little more work to do.

Currently we have only pulled it into the handheld kernel, since there were a lot of changes in the past months.
We will look how it goes with 6.13 and might then push it into the default kernels too.

[flukejones]

There will be more changes coming but the majority of things is very stable now. The one change that needs to be done is adding safe limits for the ppt for each device as a table in kernel.

I'll keep you appraised of things. It should be easier to include my full series as a single patch file

[1Naim]

Hi Luke, I'm thinking about including your asus-armoury driver for 6.14 cycle. I'm thinking about including only the armoury stuff for all kernels and only the ally stuff for the handheld kernel? What do you think?

If I'm seeing this correctly, in your wip/ally-master branch, starting from commit 7efaa140aca7ebefa86774fbe29d6936e9336c56 to HEAD is for asus-armoury and below that is for Ally. Is that correct?

[flukejones]

@1Naim You will want all patches for both branches. The asus-armoury driver contains a lot of stuff, in particular the actual min/max limits for the PPT settings you can access through ls /sys/devices/virtual/firmware-attributes/asus-armoury/attributes/ppt_*/

Do keep in mind there will be some more changes. Maybe. But right now it's in a very stable state with a lot of kinks ironed out. And the asus_armoury driver has been through a few reviews.

I'll be sending various parts for review soon.

Oh and also: master is not suitable for use on 6.13 yet. And the ally-6.13 branch isn't updated, I will backport the master work soon.

[1Naim]

You will want all patches for both branches. The asus-armoury driver contains a lot of stuff, in particular the actual min/max limits for the PPT settings you can access through ls /sys/devices/virtual/firmware-attributes/asus-armoury/attributes/ppt_*/

Oh I misphrased it :p I meant armoury for desktop kernels and armoury + ally on handheld kernels. It looks like I got my answer anyway and including the whole patchset seems to be the right way to go.

Do keep in mind there will be some more changes. Maybe. But right now it's in a very stable state with a lot of kinks ironed out. And the asus_armoury driver has been through a few reviews

All good, I see that you're still working on it and I'll probably include it in either 6.14rc2 or 6.14rc3. Thanks!

[1Naim]

The 6.14 rc kernels now have the asus-armoury and hid-asus-ally patches baked in. Both are built as modules.

[flukejones]

@1Naim please be advised that I am doing continuous work on this at the moment. Right now you will want to refresh the patch series from my wip/ally-6.14 branch

[1Naim]

Yes, I know. I can keep a close watch on patch sources everyday :). I've said this in the CachyOS discord previously, but until around rc5 or later I won't be updating the patchset again (because it keeps getting updated) unless users are reporting issues with the current iteration.

[flukejones]

@1Naim all good in the hood then. Given you have a larger userbase please do report any issues you come across.

[1Naim]

Given you have a larger userbase please do report any issues you come across

We've had at least 2 users with asusd crashing with 6.14 but no logs were shared yet so I'm still waiting on that.

[flukejones]

@1Naim there was an issue with a null pointer deref I introduced in my 6.14 branch. I've since dropped the related commits.
Man I look forward to the day Rust is fully accepted as part of the kernel.

[1Naim]

Ack. I'll update the patchset for rc4, thanks!

[flukejones]

@1Naim new update for 6.13 and 6.14 in my repo as wip/ally-. Couple of fixes and improvements (ally and a few laptops).

[flukejones]

@1Naim can you update 6.13 and 6.14 versions to be synced with my current wip/ally-6.1* please? I got a user using 6.14 for some reason and they have a crash that is solved in my last lot of updates.

[1Naim]

Done, thanks.