duplicate of #1294

duplicate of #1294

Thanks James! I am going to close #1294 as the current issue is more well-defined.

I think this is worth prioritising. If shoppers / subscribers can't add 3DS (aka SCA) credit cards as payment methods, we should either fix that or improve the error handling (if these cards are not supported for subscriptions).

I'm assuming this affects both WCPay Subscriptions and the integration with WooCommerce Subscriptions.

I'm assuming this affects both WCPay Subscriptions and the integration with WooCommerce Subscriptions.

@haszari yes, following the above steps with WC Subscriptions produces the same results.

I've moved my comments related to the bug with UPE to a new issue (#4308) since this issue is specific to non-UPE.

Tested this and I notice the form gets submitted, and Woo thinks a payment method has been added, before the 3DS modal is displayed. Eg.

• Shopper adds card details, submits form
• Page reloads, shows success message and error message (screenshots in description)
• 3DS modal is rendered here
• This is unlikely to work …

I compared with the regular (shortcode) checkout for WCPay, and pay-for-order for WC Stripe extension. In both cases, the 3DS modal is displayed before any page reloads. So maybe we need to rework the logic to ensure the 3DS modal is displayed before the form submission.

The JS code handling this UI is in checkout/classic/index.js: https://github.com/Automattic/woocommerce-payments/blob/develop/client/checkout/classic/index.js#L373

This could be the culprit:

• If we return false from the submit handler, it stops Woo from proceeding (i.e. the early page reload before 3DS modal).
• handlePaymentMethodCreation is the core of our submit handling.
• The first time it's called, it fires off an AJAX request to generate a payment method, and returns false to prevent submit.
• In the AJAX success callback, it sets paymentMethodGenerated = true.
  • In the 3DS case this might not be the whole story.
• Then handlePaymentMethodCreation is called a second time, and this time it exits early (above code snippet) and allows checkout to proceed.
  • My hunch is that this needs to check something else and wait for the 3DS modal to proceed - either in the success callback, or in the subsequent call to handlePaymentMethodCreation.

Any update on this @haszari a merchant is affected by this, I think on 8894172-zd-a8c
The user is on WooPayments version 8.6.1

@solstudioim No updates from me or Helix team (if there were we would have commented!). I suggest reaching out to product or engineering folks currently focused on subscriptions, we switched focus a while ago.

This issue might be similar to a bug we fixed in Stripe related to changing to a 3DS card after we implemented deferred intents: woocommerce/woocommerce-gateway-stripe#3539

Deferred intents changed when payment/setup intents were created and confirmed. Previously on Stripe, the intent was created on page load and then confirmed at the time of form submission. With deferred intents, the intent is now created on form submission and later validated/confirmed during the process_payment() function which broke out compatibility with this feature (not sure if WooPayments does things the same).

In order to fix this issue, we had to return false on the woocommerce_subscriptions_update_payment_via_pay_shortcode filter. which prevents WooCommerce Subscriptions from updating the payment method before the customer had authed the payment and the intent was confirmed.

This issue existed for a long time now, as it was there with the good old UPE too. The PR mentioned by Matt above is pretty helpful. On top of that, we still need to handle a couple of WooPayments-specific areas:

1. Allow order meta to be updated for the change payment method use-case to ensure intent IDs alignment
2. Enhance 3DS intent confirmation AJAX to get the correct type of intent (our flow currently is not able to recognize it's a "change pm for subscription" use-case and attempts to fetch payment intents instead
3. Add the correct redirect as currently, assuming the above two points are addressed, I'm redirected to order received page

There might be more things in it but the above ones are the bigger ones for now.